search

moneyphp / money

PHP implementation of Fowler's Money pattern.
http://moneyphp.org
MIT License
4.63k stars 441 forks source link

Remove Currencies from constructor BitcoinMoneyFormatter #524

Closed frederikbosch closed 5 years ago

frederikbosch commented 5 years ago

It does not make sense to inject Currencies into since it is used for only 1 currency and all unknown factors are static.

frederikbosch commented 5 years ago

I decided to drop this issue. If someone creates an own implementation of Currencies for Bitcoin, with a different subunit, then it can still use the formatter. Therefore I think it is fine to leave it as is.

gmponos commented 5 years ago

At least add a docblock about it in order not to be spawned again?