Add php8 support - Githubissues

sspat commented 3 years ago

Closes #619

PHP 5.6, 7.0, 7.1 and 7.2 had to be dropped, mostly due to testing tools versions that support 8.0 dropping them, main issues were with phpspec.
Some dataprovider value types had to be changed from string to float because of a bc break in sebastianbergmann/comparator, see https://github.com/sebastianbergmann/phpunit/issues/3185
Fixed running Psalm in CI using vimeo/psalm-github-actions, there were multiple errors: https://github.com/moneyphp/money/runs/1597930547?check_suite_focus=true => https://github.com/sspat/money/runs/1627743511?check_suite_focus=true
Symfony PHPUnit bridge was removed because there is no point left in it after dropping the older php versions
Fixed usage of deprecated methods in phpunit tests

sagikazarmark commented 3 years ago

@sspat thanks! I'm gonna have to think about dropping PHP 5.6/7.x support a little (ie. should we make a new major release for that?). Other than that 👍

sspat commented 3 years ago

taggable-cache, exchanger, swap - all had major bumps with some api changes and deprecations so even if money will be updated as a minor version change to get php8 support, these dependencies will still need a major update with breaking changes.

PowerKiKi commented 3 years ago

should we make a new major release

No, this should not be a major release, because moneyphp/money's API is not changed by this PR. Composer will take care of selecting the appropriate version of moneyphp/money dependending on PHP version. There is not need to make this a major version.

And since it already is mentioned clearly in the changelog, there is nothing else to do than merge and and release as minor version.

frederikbosch commented 3 years ago

Only v4 will support PHP8.0+. Thank you for your effort and I am sorry I did not pay attention to this earlier on.

moneyphp / money

Add php8 support #622