search

moneyphp / money

PHP implementation of Fowler's Money pattern.
http://moneyphp.org
MIT License
4.6k stars 440 forks source link

Remove ext-json from required in composer.json #653

Closed tuqqu closed 3 years ago

tuqqu commented 3 years ago

Extension JSON is part of PHP core since version 8, there is no need to specify it in the composer.json file any longer.

frederikbosch commented 3 years ago

@tuqqu This looks fine, but just curious: how did you find out about this?

tuqqu commented 3 years ago

:) I was going through the changelog for PHP8 when noticed there was a dedicated RFC for this.

frederikbosch commented 3 years ago

Thanks, attentive! Since this change does not have any actual substance, I won't create a tag for this.

Ocramius commented 3 years ago

Note: even if it is part of core (and bundled with it), it is still a dependency.

frederikbosch commented 3 years ago

@Ocramius And therefore it should be readded as a dependency?

Ocramius commented 3 years ago

Maybe: no strong feelings though.

Adding maglnet/composer-require-checker would expose this and other hidden dependencies.

On Mon, Jun 21, 2021, 12:19 Frederik Bosch @.***> wrote:

@Ocramius https://github.com/Ocramius And therefore it should be readded as a dependency?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/moneyphp/money/pull/653#issuecomment-864916836, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABFVEA4MC6M4YR3ORQCY23TT4G3PANCNFSM45VE2VKQ .

frederikbosch commented 3 years ago

Created issue #658 for this, thanks for the suggestion.