search

moneyphp / money

PHP implementation of Fowler's Money pattern.
http://moneyphp.org
MIT License
4.6k stars 440 forks source link

Full PHP 8.1 support #670

Closed driesvints closed 2 years ago

driesvints commented 2 years ago

~Blocked by https://github.com/phpspec/phpspec/pull/1397 a new tag on PhpSpec.~

driesvints commented 2 years ago

@frederikbosch can you maybe approve the workflows here so the builds can run and I can look into more fixes that are needed for PHP 8.1?

driesvints commented 2 years ago

In the meantime we've circumvented the deprecations through Laravel. I'll leave this PR open though and follow along with the PhpSpec developments.

frederikbosch commented 2 years ago

Early support for PHP 8.1 via new release 4.0.3. Please tag me as soon as PHPspec blocking PR is merged. Then I will try to provide full support by helping getting this PR out of the door.

driesvints commented 2 years ago

My PR got closed but https://github.com/phpspec/phpspec/pull/1407 was merged. Waiting for it to be tagged.

frederikbosch commented 2 years ago

Cool, please let me know when we can proceed here.

driesvints commented 2 years ago

@frederikbosch PhpSpec added a new tag. I bumped the version here. Can you approve the workflows so I can see if there's tests failing?

frederikbosch commented 2 years ago

Why isn't the workflow running for your c169254 commit?

driesvints commented 2 years ago

@frederikbosch unsure because they seem to be running on my fork: https://github.com/driesvints/money/actions

Phpbench seems to still be failing here: https://github.com/driesvints/money/runs/5535118972?check_suite_focus=true#step:7:223

driesvints commented 2 years ago

I bumped both Phpbench and PhpSpec. But now I'm getting quite a lot of Psalm errors because I needed to bump Psalm to the latest version.

@frederikbosch I'd appreciate any help with solving these.

frederikbosch commented 2 years ago

@driesvints I saw what you were doing- have been pushing the approve button the whole time. Great work for now already. I'll try to have a look at these psalm errors this week.

driesvints commented 2 years ago

Thanks @frederikbosch!

frederikbosch commented 2 years ago

Merci beaucoup @driesvints!

driesvints commented 2 years ago

Awesome, thanks @frederikbosch!