search

moneyphp / money

PHP implementation of Fowler's Money pattern.
http://moneyphp.org
MIT License
4.62k stars 440 forks source link

Unit Test for CurrencyPair - iso string parse FAILS #695

Closed devsi closed 2 years ago

devsi commented 2 years ago

Running the unit tests against the built lib, all pass but 1. 

There was 1 failure:

1) Tests\Money\CurrencyPairTest::it_parses_an_iso_string
assert(is_numeric($matches[2])) in /app/src/CurrencyPair.php:65

FAILURES!
Tests: 1790, Assertions: 2599, Failures: 1.

Should be a fairly straight forward fix to get this to pass. I'll take a look myself if I get time and submit a PR. Otherwise leaving this here for a contributor to pick up!

Notable Files@Methods:

src/CurrencyPair@createFromIso tests/CurrencyPairTest@it_parses_an_iso_string

Thanks :)

frederikbosch commented 2 years ago

Why does it fail for you, and is the test suite not failing?

frederikbosch commented 2 years ago

Closed by #700