Fix: ISO parsing invalid assertions for CurrencyPair

[sudkumar]

With iso as EUR/USD 1.2500, we will get $matches = ['EUR/USD 1.2500', 'EUR', 'USD', '1.2500'] after pref_match but the assertion expects $matches[2] to be numeric which seems to be incorrect. Just updated the assertion to not expect an empty string.

assert($matches[1] !== '');
- assert(is_numeric($matches[2]));
+ assert($matches[2] !== '');

fixes #695

Warning : Not ready for merge. The changes have been reverted to showcase the issue with existing implementation.

[frederikbosch]

Can you include a test on the example that fails?

[sudkumar]

@frederikbosch I have reverted the implementation and added a test to show the failure.

[frederikbosch]

@sudkumar The tests pass. So the question is: why does it fail on your end?

[sudkumar]

Hmmm.. interesting 🤔. BTW, there are two directories of tests. composer test executes from specs dir.

[frederikbosch]

What is inside $matches when you execute the test? Can you show the result of the following var_dump here?

var_dump($iso, $matches);

[sudkumar]

Here it is.

> var_dump($iso, $matches);

string(16) "EUR/USD 1.250000"
array(4) {
  [0]=>
  string(16) "EUR/USD 1.250000"
  [1]=>
  string(3) "EUR"
  [2]=>
  string(3) "USD"
  [3]=>
  string(8) "1.250000"
}

System:

• PHP: 8.1.7
• Composer: 2.3.7

Here is the exception when running composer test

----  broken examples

        Money/Currencies/BitcoinCurrencies
  32  ! is iterable
        exception [err:AssertionError("assert(is_array($subject))")] has been thrown.

        Money/Currencies/CurrencyList
  45  ! is iterable
        exception [err:AssertionError("assert(is_array($subject))")] has been thrown.

        Money/CurrencyPair
  30  ! parses an iso string
        exception [err:AssertionError("assert(is_numeric($matches[2]))")] has been thrown.

21 specs
108 examples (105 passed, 3 broken)
150ms

[sudkumar]

What do you get with var_dump($iso, $matches); ?

[sudkumar]

Am I missing something obvious here!! 😄

[frederikbosch]

@sudkumar Thank you very much, I have fixed the issue. zend.assertions was not enabled in CI. That's why it was not throwing. Your observation was correct.

[sudkumar]

So glad we found the issue. Thank you for looking into it.