search

moneyphp / money

PHP implementation of Fowler's Money pattern.
http://moneyphp.org
MIT License
4.62k stars 440 forks source link

BCMath is unmaintained #718

Closed pevdh closed 1 year ago

pevdh commented 1 year ago

The bcmath extension has not had a maintainer since 2004 [ref]. This is currently preventing us from upgrading to 4.0, since our policy prevents us from enabling the bcmath extension.

Would it be possible to make the bcmath extension an optional requirement? I'd be happy to submit a PR.

arokettu commented 1 year ago

You can declare that bcmath exists in config.platform or install a bcmath polyfill like https://github.com/phpseclib/bcmath_compat

frederikbosch commented 1 year ago

Great suggestions @arokettu. But I leave this issue open for ow. I agree with @pevdh, making bcmath required while it is actually unmaintained deserves our attention. Maybe @Ocramius can help to shed us his thoughts on this remark.

Ocramius commented 1 year ago

ext-bcmath is maintained as part of php-src: https://github.com/php/php-src/tree/3fb7198034c0f2ed49eeb71f9757b58aaa26260d/ext/bcmath

It receives regular updates, and is not unmaintained?

frederikbosch commented 1 year ago

I have proposed to change the status in PHP SRC to prevent any further indistinctness.

frederikbosch commented 1 year ago

The status of BCMath has been changed in PHP-SRC. It is now listed as Maintained.