moneyphp / money

PHP implementation of Fowler's Money pattern.
http://moneyphp.org
MIT License
4.62k stars 440 forks source link

PHPUnit comparator breaks under PHPUnit 10/comparator 5 #745

Closed Firehed closed 8 months ago

Firehed commented 1 year ago

There was a breaking change going from sebastian/comparitor:4 to 5, which by default you'll pull in updating to PHPUnit 10.

At a glance, there are two adjustments:

I think the latter is fine for forward compatibility, but the former may require some hacking to get around the loss of constructor

I'll take a quick attempt at a PR to address this.

frederikbosch commented 8 months ago

Fixed by #784.