search

moneyphp / money

PHP implementation of Fowler's Money pattern.
http://moneyphp.org
MIT License
4.56k stars 439 forks source link

Allow `psr/cache: ^1.0|^2.0|^3.0` #771

Closed umpirsky closed 5 months ago

frederikbosch commented 6 months ago

This is great. I don't see any reason not to merge this.

frederikbosch commented 6 months ago

Well, why did you went from ^1.0.1 to ^1.0. And why did we use ^1.0.1 to begin with. I don't have time to look into this history, not right now. Do you know why that might have been done? And why did you allow 1.0.0? Maybe ^1.0.1 || ^2.0 || ^3.0 is safer.

umpirsky commented 5 months ago

Whatever you prefer. I just want to allow 2.0 since 1.0.1 is released 8 years ago.

frederikbosch commented 5 months ago

Let's go for ^1.0.1 || ^2.0 || ^3.0, then I'll merge.

umpirsky commented 5 months ago

Done.

frederikbosch commented 5 months ago

I will create a tag for this this week.

frederikbosch commented 5 months ago

Thanks for the work!

umpirsky commented 5 months ago

Thanks for merging that fast. :+1:

umpirsky commented 5 months ago

@frederikbosch Any updates on this?