search

moneyphp / money

PHP implementation of Fowler's Money pattern.
http://moneyphp.org
MIT License
4.56k stars 439 forks source link

feat: bump dev-dependencies #775

Closed Chris53897 closed 5 months ago

Chris53897 commented 5 months ago

Related to https://github.com/moneyphp/iso-currencies/pull/15

frederikbosch commented 5 months ago

This might be much more work than you anticipated, because the static analyzers might have quite something to complain.

frederikbosch commented 5 months ago

That things with that comma added to every argument list, can you disable that? Personally, I do not see why we want that. I makes this PR really hard to check also.

Chris53897 commented 5 months ago

The rules need to be changed here. But i am not which one to add here. https://github.com/moneyphp/money/blob/master/phpcs.xml.dist

I am not yet sure what exactly does cause the changes for PHPCSFixer to find, all the new violations. https://github.com/moneyphp/money/actions/runs/7665540242/job/20891619569

frederikbosch commented 5 months ago

It is caused by the upgrade of doctrine/coding-standard. To be honest, I have no idea either which config it is. I looked up the docs but I am not sure actually.

frederikbosch commented 5 months ago

Can you try to exclude SlevomatCodingStandard.Functions.RequireTrailingCommaInCall and SlevomatCodingStandard.Functions.RequireTrailingCommaInClosureUse?

Chris53897 commented 5 months ago

I think splitting it up to seperate PR's make it easier. Maybe you can have a look at the other two PR's from me. After that is merged, https://github.com/moneyphp/money/pull/746 could be rebased against master. And hopefully finalised, and merged.

After that is done a new PR for the coding standards could be done. WDYT ?

frederikbosch commented 5 months ago

Ok. Let's do the coding standards upgrade here then.

frederikbosch commented 5 months ago

Superseded by #785