search

moneyphp / money

PHP implementation of Fowler's Money pattern.
http://moneyphp.org
MIT License
4.56k stars 439 forks source link

tests: mark test as skippable if locale is not available #777

Closed Chris53897 closed 5 months ago

Chris53897 commented 5 months ago

This tests fails for me locally, because i do not have the locale installed. I have to run tests one by one instead of composer test With this change it makes it easier to test local.

frederikbosch commented 5 months ago

But, if in CI, the test must fail if the locale is not there. So this solution is a little too easy.

Chris53897 commented 5 months ago

ok, i will think about a more robust solution.

Chris53897 commented 5 months ago

Is it valid to change it to a more commonly used Locale? I guess US is comma seperated and the sense of the test ist still correct. Please check this.

frederikbosch commented 5 months ago

I rather leave it as is.