moneyphp / money

PHP implementation of Fowler's Money pattern.
http://moneyphp.org
MIT License
4.56k stars 439 forks source link

chore: upgrade PHPUnit 9 => 10 #780

Closed Chris53897 closed 5 months ago

Chris53897 commented 5 months ago

changes for sebastian/comparator

https://github.com/moneyphp/money/pull/746 rebased against master. Migrate Config PHPUnit 9 => 10 Only Allow PHPUnit 10.

I did not have a closer look to the comperator changes.

Chris53897 commented 5 months ago

Tests are failing, because of DeprecatedMethod: The method PHPUnit\Framework\TestCase::setLocale has been marked as deprecated (see https://psalm.dev/001)

Chris53897 commented 5 months ago

I replaced it with direct calls to setlocale(). But i am not sure if this is enough.