moneytoo / Player

▶ Simple and lightweight, yet polished and powerful Android video player based on ExoPlayer
https://play.google.com/store/apps/details?id=com.brouken.player
The Unlicense
1.54k stars 180 forks source link

Silence skip feature #17

Open barolo opened 3 years ago

barolo commented 3 years ago

Exo provides great feature called silence skip and I was amazed by its implementation in NewPipe, unfortunately it doesn't play local files. When you don't look at the video it's actually really hard to spot places where it is skipped. Thus I would like ask for inclusion of this feature [ possibly together with speedup functionality ].

moneytoo commented 3 years ago

Sounds interesting. I try that out.

Can you point out your use case / with what video does this feature makes sense? Can you share a sample?

moneytoo commented 3 years ago

IMHO this is something that would be useful for podcasts instead of movies and TV shows. I would expect it to be more bound to online content. Just Player also currently doesn't have any background or music playback as it's originally intended for movies/shows. Playback speed setting is already there (as it's provided by ExoPlayer UI).

barolo commented 3 years ago

It's great for any kind of educational content, classes etc. which many of us are in the midst of. In one case this feature cut one of my videos from 2 hours to one, without speeding up, and it is far much pleasant to listen to. Podcasts are pretty much covered by PocketCasts which have such feature too, it's closed source but oh well

AkitoFire commented 3 years ago

I would also advocate for the addition of this silence skip feature. Like barolo mentioned, it is very useful for educational content (for example, I'm currently watching recordings of my lectures and this feature would be much more helpful than simply increasing the playback speed). Also, I think no other player offers this feature (I only know about NewPipe, but that doesn't really count), neither on Android nor on Desktop platforms. There are ways to reencode those videos but that is time-consuming and costs much more space.

moneytoo commented 3 years ago

You can try builds available here which have skip silence enabled (but lack UI to toggle that). See how well it works for your content.

barolo commented 3 years ago

@AkitoFire AntennaPod offers such feature, since it can play videos now, it's not intuitive since you need to add folder with videos first.

I'll check the new builds

barolo commented 3 years ago

@moneytoo That build works great! In the future I would love to have an option to 2x/3x fastforward through silence instead skipping.

AkitoFire commented 3 years ago

@moneytoo Thank you! I'm not entirely sure what the difference between both builds is, but it works really well! With quieter content, the output is a garbled mess though. One possible solution for this problem would be to check for a loudness standard and adjust accordingly (specifying target LUFS, for example), but I'm not sure how to implement something like this for a normal video player.

barolo commented 3 years ago

@moneytoo is there a plan to include this in release builds?

moneytoo commented 3 years ago

@moneytoo is there a plan to include this in release builds?

Maybe in the future, but I can't promise anything. It would probably be available only after activating some advanced mode (I still need to think though that more).

barolo commented 3 years ago

@moneytoo is there a plan to include this in release builds?

Maybe in the future, but I can't promise anything. It would probably be available only after activating some advanced mode (I still need to think though that more).

Gotcha, thank you for updating the builds.

barolo commented 3 years ago

@moneytoo Could you please update the builds?

barolo commented 3 years ago

@moneytoo thank you for updates!

I have a request, could you perhaps tie playback speed to silence skip, instead of just skipping, e.g. 3x speed. It's much less jarring. That's how the NewPipe guys do it.

moneytoo commented 3 years ago

Starting v0.59 you can enable the basic audio skip from settings. You can access settings from system App info screen (phones only) or by long pressing the gear (⚙️) icon (phones/TV).

barolo commented 3 years ago

Starting v0.59 you can enable the basic audio skip from settings. You can access settings from system App info screen (phones only) or by long pressing the gear (gear) icon (phones/TV).

Marvelous! Just updated all of my devices. Thank you.

Will you consider my request of speeding up instead of cutting for skipping?

theScrabi commented 2 years ago

@moneytoo awesome 😍 but was it possible to adjust the threshold at which scipping occures? Because for my lectures to much is sciped, so understanding spoken sentences is not possible anymore.

User087 commented 8 months ago

Am I correct in thinking that this: https://github.com/google/ExoPlayer/issues/6705 having been resolved should make it possible to enable the user to configure parameters of the skip-silence feature, so they can change the minimum duration of silence to be skipped, the threshold volume below which is classified as 'silence', and the duration of 'padding' on the edges of any silent portion?