moneytoo / Player

▶ Simple and lightweight, yet polished and powerful Android video player based on ExoPlayer
https://play.google.com/store/apps/details?id=com.brouken.player
The Unlicense
1.83k stars 191 forks source link

Can not use remote control on TV BOX #26

Closed aston314 closed 3 years ago

moneytoo commented 3 years ago

Can you be more specific? What box (model) are you using? What controls are you trying? Are you able to pause playback when Just Player is playing in foreground?

Generally remote controls should work (as the player uses mediasession), for example buttons on Bluetooth headset etc.

aston314 commented 3 years ago

I use ZIDOO X9S. When the toolbar dispear,I can not use the remote control do anything.Just can exit. Can not forward or control the sound.

moneytoo commented 3 years ago

It should work with pure media buttons (play/pause, volume) but it doesn't work with navigation/arrow keys. I tried the player on Android TV (mi box) and it's probably the same case. Currently only touchscreen is supported, but this is something I would like to improve.

aston314 commented 3 years ago

Thank you.

Pentaphon commented 3 years ago

I don't think this player is really meant for remote control aka Android TV use. There's other players that already do that like Nova, VLC, Kodi and KM and it took a LOT of work for those players to get to that point. I think of this player as a tiny but capable player for touchscreens only. I see JustPlayer as an alternative to mpv-android and that's fine with me because they have different backends.

aston314 commented 3 years ago

My wrong. Have uninstalled.

moneytoo commented 3 years ago

Supporting TV boxes based on pure Android should be doable and I will try that eventually. UI should be controllable already if focus is working (might needs tweaking here and there) and then there are only missing playback controls using navigation keypad.

Android TV is a bit complicated as there's no system file chooser built in but a single library can fix that.

Pentaphon commented 3 years ago

Android TV is a bit complicated as there's no system file chooser built in but a single library can fix that.

If you do support Android TV, you will definitely get people who ask for FireTV support since there's way more users of those devices but it shouldn't be hard to make sure both are supported.

Thanks for opening this player up to more devices.

moneytoo commented 3 years ago

Latest version (v0.20 - currently here) includes improvement that should make it usable on Android TV. Though:

Android TV is missing native file chooser so opening files from within Just Player isn't currently supported. If you install Material Files, you will be able to open files, but from internal storage only. If you need to open file from external storage, select and open it from a file manager. Pretty good and simple is this File manager.

Let me know what could be improved (except for adding file chooser, obviously). I may eventually add built in file chooser but the only device I have (Mi Box S) is actually pretty buggy and resizing picture doesn't work correctly so that's something I want to resolve first.

joaopedromfigueiredo commented 3 years ago

Latest version (v0.20 - currently pre-release here) includes improvement that should make it usable on Android TV. Though:

Android TV is missing native file chooser so opening files from within Just Player isn't currently supported. If you install Material Files, you will be able to open files, but from internal storage only. If you need to open file from external storage, select and open it from a file manager. Pretty good and simple is this File manager.

Let me know what could be improved (except for adding file chooser, obviously). I may eventually add built in file chooser but the only device I have (Mi Box S) is actually pretty buggy and resizing picture doesn't work correctly so that's something I want to resolve first.

Thanks for that!

moneytoo commented 3 years ago

I'm adding android-file-chooser to the -online builds (starting v0.36) so you can properly open files on Android TV. Comparing to using Material Files, the new file chooser is able to access USB storage and navigation starts in the last opened folder so it should be more pleasant to use.

There's also support for auto frame rate switching: https://github.com/moneytoo/Player/issues/98

If you want to test it early, download a build from https://brouken.com/player/

Santos2004 commented 3 years ago

no disk selection

in version 0.36 in Android-file-chooser I can choose either internal storage or disk in Fat32. the disk in exfat is not listed at all Ugoos x3pro

https://user-images.githubusercontent.com/78390645/121804245-0f3b6c00-cc4e-11eb-8a14-44e11f24c140.MOV

Santos2004 commented 3 years ago

correction.
it's all about the Master Boor Record. Only! if the disk partitions are in it, then everything is fine. if in GUID Partition Map then your new explorer in Just does not see either exFAT or Fat32. But all other programs and Android see everything correctly.

moneytoo commented 3 years ago

@Santos2004 Is that Android TV device or some other Android box? Did you use file chooser in the previous versions? If yes, then download newer version from: https://github.com/moneytoo/Player/releases/tag/v0.36

moneytoo commented 3 years ago

As I wrote in https://github.com/moneytoo/Player/releases/tag/v0.36

Right now the changes related to better support for TV boxes are only in the -online version. After more testing/feedback, it will be probably unified. (I will attempt to include Android TV in distribution on Google Play.)

Finally, I think that Just Player should be usable on Android TV / TV boxes. I'm personally starting to use it as my primary player even on Android TV. I made lots of improvements and feel good about that (at least within the limits of this simple player and my abilities 😜). So let me know about your experience.

Santos2004 commented 3 years ago

Thank you so much ended. Last version with new file explorer working correctly with usb disk exfat on GUID Partition Map. But. Files on mp4 with Dolby Vision playing with drop frames. Files mkv playing on same disk correctly and smooth. It's very old problem. 0.34 too. May be early. It's just player problem only. Other players working correctly Please fix it too! Thank you. Great work!

aston314 commented 3 years ago

Can not switch subtitles on TV.

moneytoo commented 3 years ago

Can not switch subtitles on TV.

What Android OS version has your device? There's an issue with older OS versions (at least on 7.0): https://github.com/google/ExoPlayer/issues/9061 Could that be this case?

aston314 commented 3 years ago

Android 6

moneytoo commented 3 years ago

Android 6

Thats probably the mentioned ExoPlayer issue. I reported this to them only two days ago so lets wait for their response.

Santos2004 commented 3 years ago

Beautiful file manager here. Here is good file manager as part of Torrserve

https://github.com/YouROK/TorrServe/tree/master/app/src/main/java/ru/yourok/torrserve/ui/dialogs

vladlenas commented 3 years ago

Android 6

Thats probably the mentioned ExoPlayer issue. I reported this to them only two days ago so lets wait for their response.

I support, in 0.37 the manager opens the file in com.android.documentsui. On boxes with Android TV, this does not work from the remote control.

Santos2004 commented 3 years ago

Yes it's true

MadAndron commented 3 years ago

Perhaps the best solution would be to make a system file open dialog. That is, make a choice which file manager to open

moneytoo commented 3 years ago

I support, in 0.37 the manager opens the file in com.android.documentsui. On boxes with Android TV, this does not work from the remote control.

I try detecting whatever there's documentsui even on Android TV as I believe I read somewhere that some devices like Nvidia Shield actually support that. This worked for me on my Xiaomi Mi Box S and Android TV emulators (as they don't have such stubs). However I also had a problem on other Android TV box (from Geniatech) and the only option was to blacklist that.

I guess I will switch to using the custom file chooser on all the Android TV devices and boxes (if at least the detection will work correctly). Offering choice from multiple file choosers would be the last resort (as it brings one more step, probably requires new translatable strings etc.).

vladlenas commented 3 years ago

I try detecting whatever there's documentsui even on Android TV as I believe I read somewhere that some devices like Nvidia Shield actually support that.

Shield 2019 Pro - opens in documentsui and it doesn't work. Tivo 4K Stream and Chromecast with Google TV - "You don't have an app that can do this". Fire TV Stick 4K - opens in the Fire OS manager, but there I have a root and froze the documentsui.))

moneytoo commented 3 years ago

@vladlenas Please try Just.Player.v0.38.apk. The system file chooser (documentsui) shouldn't be used on these devices at all. (If device is either television or notouch.)

vladlenas commented 3 years ago

@vladlenas Please try Just.Player.v0.38.apk. The system file chooser (documentsui) shouldn't be used on these devices at all. (If device is either television or notouch.)

Now on all my devices opens the file chooser.

vladlenas commented 3 years ago

But I still don't use Just to open files, since I have all the content on Nas. I don’t have any problems to open in another manager and select Just. But for those who have a hard drive connected, this is a very useful feature.

vladlenas commented 3 years ago

And yet, the bad thing is that when you open the player, the last video starts immediately. If opened from another manager or using TorrServe, we always get a "resource error" after closing opening of the player. It would be nice to be able to disable this feature.)

Santos2004 commented 3 years ago

and the choice of file also does not work quite correctly. I have an sd card and a usb disk in the console. I see only sd. when I remove sd I start to see the disk. but not both at once !!! but must see both !!! ' here's a much better file chooser Please try it:

https://github.com/YouROK/TorrServe/tree/master/app/src/main/java/ru/yourok/torrserve/ui/dialogs

moneytoo commented 3 years ago

@Santos2004 I will look into that.

moneytoo commented 3 years ago

@Santos2004 I'm adding a workaround to list the content of /storage where are the mount points of all removable volumes.

Santos2004 commented 3 years ago

@Santos2004 I'm adding a workaround to list the content of /storage where are the mount points of all removable volumes.

Cool. Where new release?😀

moneytoo commented 3 years ago

@Santos2004 You can try it here: Just.Player.v0.38b.apk

Santos2004 commented 3 years ago

@Santos2004 You can try it here: Just.Player.v0.38b.apk

This release working perfect. Great work! Thank you so much!!!

Santos2004 commented 3 years ago

Can you add more details in sound tracks choice? Name of translater for example...

moneytoo commented 3 years ago

@Santos2004 Thanks for confirming. I can eventually improve it to list all individual volumes but that should be enough at least for now.

more details in sound tracks choice

If you can, create separate issue and share same details about the media (and provide at least Media info output). Cause I'm not really sure if there is some info like that in general - as I already print the track label.

Santos2004 commented 3 years ago

sorry for the slight inaccuracy. we are only talking about multitrack mp4! everything is fine in mkv files. but maybe you can extract more complete information like windows or plex already does?

moneytoo commented 3 years ago

Can not switch subtitles on TV.

ExoPlayer devs already already fixed the underlying issue so I included it in v0.38. That should allow full usage on Android TV/boxes.

moneytoo commented 3 years ago

Just Player is now available on Google Play even for Android TV devices. I believe that the original issue is resolved now so I'm going to close this one. But feel free to create any new issue. Thank you all for all the feedback and patience!