moneytoo / Player

▶ Simple and lightweight, yet polished and powerful Android video player based on ExoPlayer
https://play.google.com/store/apps/details?id=com.brouken.player
The Unlicense
1.57k stars 182 forks source link

SSA Subtitles Problem #332

Closed rahaaatul closed 1 year ago

rahaaatul commented 2 years ago

Problem

Comparison

How it is Vs How it should be

Requirements:

Tested with:

Tested on: Device: Android TV OS: 5.1 RAM: 512 MB GPU: Mali-450 MP

IMG_20220718_183900.jpg Just Player

IMG_20220718_184054.jpg MX Player


IMG_20220718_183905.jpg Just Player

IMG_20220718_184057.jpg MX Player


IMG_20220718_183908.jpg Just Player

IMG_20220718_184101.jpg MX Player


IMG_20220718_183911.jpg Just Player

IMG_20220718_184104.jpg MX Player

moneytoo commented 2 years ago

Please share a sample of the video/subtitle file. Can you duplicate this issue on other devices as well (a phone or tablet)?

Root-FTW commented 2 years ago

Please share a sample of the video/subtitle file. Can you duplicate this issue on other devices as well (a phone or tablet)?

Here is a example of this error:

https://**************/%5BErai-raws%5D%20Hunter%20X%20Hunter%20-%20020%20%5B1080p%5D%5BMultiple%20Subtitle%5D.mkv

moneytoo commented 2 years ago

Thank you for the source. I can duplicate the issue so I removed the link and will debug that.

Root-FTW commented 2 years ago

Thank you for the source. I can duplicate the issue so I removed the link and will debug that.

@moneytoo Thank you very much for this project, I currently use it on my firestick 4k along with stremio, a few days ago I published another ticket in which I explained that this is the best player that exists in the world (I have tried all the ones that exist) I was able to play the movie "interstellar" that weighed more than 90GB in less than 2 seconds, and the same with the movie "the shining" of more than 130gb, the 2 movies were in 4k + HDR + Dolby vision +AC3 5.1 and in both cases the file played in less than 2 seconds.

There is only one UNIQUE detail missing to make it the best player on the planet, to be able to obtain subtitles from online sources, for example OpenSubtiles, if you manage to do that, please let me know, I am willing to collaborate with a donation to your project $

Thanks for ALL

rahaaatul commented 2 years ago

Please share a sample of the video/subtitle file. Can you duplicate this issue on other devices as well (a phone or tablet)?

I just played the same video on my Phone. And it's giving me this error -

IMG_20220720_125911 IMG_20220720_125853

Plays fine with other players.

Also thanks to @Root-FTW for providing a sample.

moneytoo commented 2 years ago

The partial background issue should be fixed in version 0.122. Some notes:

Root-FTW commented 2 years ago

The partial background issue should be fixed in version 0.122. Some notes:

  • You can disable the subtitle background in captioning preferences
  • The font size in these files seems to be larger than probably expected. This seems to be a current ExoPlayer limitation with SSA. You can work around it by enabling device captions which will prevent applying some SSA stylings.

Any update for online subtitles, to be able to load subtitles from Opensubtitles?

moneytoo commented 2 years ago

Any update for online subtitles, to be able to load subtitles from Opensubtitles?

https://github.com/moneytoo/Player/issues/323#issuecomment-1176649687

rahaaatul commented 2 years ago

The partial background issue should be fixed in version 0.122.

Yes, it fixed it. IMG_20220723_151618

My TV doesn't have accessibility settings, nor the option to change caption settings. It do have a APK called com.droidlogic.SubTitleService but it's not launchable.

This issue is still here. Probably because the styled font is black? IMG_20220723_151549

I sent you video file via email, check it out.

moneytoo commented 2 years ago

My TV doesn't have accessibility settings, nor the option to change caption settings.

To quickly access the system Caption preferences screen, long tap the subtitle button.

rahaaatul commented 2 years ago

To quickly access the system Caption preferences screen, long tap the subtitle button.

Thank you for the info. But, Upon long tapping the subtitle button a toast appears: Files app is disabled or missing And if I tap details, a pop-up appears: Intent {act=android.settings.CAPTIONING_SETTINGS}