search

moneytoo / Player

▶ Simple and lightweight, yet polished and powerful Android video player based on ExoPlayer
https://play.google.com/store/apps/details?id=com.brouken.player
The Unlicense
1.57k stars 183 forks source link

Add libass support! #409

Closed vegedb closed 1 year ago

vegedb commented 1 year ago

https://github.com/libass/libass image

As you can see, its weird not to see Just Player in here seeing its open sourced like the others. ASS/SSA subs is the only thing missing for Just player. Particularly for Anime fans!

Hope you could add it too!

moneytoo commented 1 year ago

This is a job for ExoPlayer: https://github.com/google/ExoPlayer/issues/8435#issuecomment-759327563

vegedb commented 1 year ago

@moneytoo Its an entirely separate entity from exoplayer. Emby and plex (recently added libass) android players both use exoplayer and libass on top of it.

Hope you can look it up.

vegedb commented 1 year ago

https://libass.github.io/JavascriptSubtitlesOctopus/videojs.html https://libass.github.io/JavascriptSubtitlesOctopus/index.html

Here are some JS examples on browser players using libass.

vegedb commented 1 year ago

Configuring subtitle renderer possible in Just player?

Libass is an open source subtitle renderer and a replacement for the VSfilter.

Example, 1) on MPC-HC, you could change it by pointing to a folder with libass. 2) on MPV, you could point a "script" folder with latest libass

moneytoo commented 1 year ago

If there were any publicly available patches/integration of libass in ExoPlayer, I would include them. Unfortunately, no one is sharing that. It would be needed to be implemented in the engine so it's really not a task for Just Player.