search

moneytoo / Player

▶ Simple and lightweight, yet polished and powerful Android video player based on ExoPlayer
https://play.google.com/store/apps/details?id=com.brouken.player
The Unlicense
1.46k stars 172 forks source link

The text styles from subtitles does not works #459

Closed ghost closed 1 year ago

ghost commented 1 year ago

This player always uses custom text styles, even the subtitles with text styles. I suggest that default to use the text style from subtitles, and add an option to force custom text styles.

moneytoo commented 1 year ago

https://github.com/moneytoo/Player#how-do-i-change-subtitle-font-size-or-color

If you want to apply additional formatting defined in subtitles, leave this option off.

ghost commented 1 year ago

Thanks. But some param from subtitles does not work, like fontname, even if the video file with the font attachment.

moneytoo commented 1 year ago

What subtitle format is that? In case of SSA the support is quite limited: https://github.com/google/ExoPlayer/issues/8435#issuecomment-762449001

ghost commented 1 year ago

ASS subtitles and TTF font in MKV file

Part of reporting from MediaInfo

General
Format                         : Matroska
Attachments                    : jf-openhuninn-1.1.a.ttf

Text
Format                         : ASS
Codec ID                       : S_TEXT/ASS
Codec ID/Info                  : Advanced Sub Station Alpha

This font not installed on the system, it only inside the mkv file. I am sure the font name is correct, because that works in other player, like VLC.

moneytoo commented 1 year ago

In this case it's indeed limited by the support of ExoPlayer/Media3.