search

moneytoo / Player

▶ Simple and lightweight, yet polished and powerful Android video player based on ExoPlayer
https://play.google.com/store/apps/details?id=com.brouken.player
The Unlicense
1.44k stars 171 forks source link

Subtitles #486

Closed JonathanAkaJD closed 8 months ago

JonathanAkaJD commented 1 year ago

Not really a bug but curious if it would be possible for you to add a toggle in settings to disable subtitles by default? It's frustrating that subtitles turn on automatically every time I start something.

moneytoo commented 1 year ago

I'm planning on changing that behavior. Meanwhile you should be able to disable that in advanced settings).

Some advanced features can be enabled or configured in settings. To access it, long press the ⚙️ gear icon. (Alternatively, you can also enter this settings from App info screen.)

VasilisKos commented 1 year ago

I'm planning on changing that behavior. Meanwhile you should be able to disable that in advanced settings).

Some advanced features can be enabled or configured in settings. To access it, long press the gear gear icon. (Alternatively, you can also enter this settings from App info screen.)

I think it should be kept as it is. It's probably more convenient for most users. The respective advanced setting is just fine.

moneytoo commented 1 year ago

@VasilisKos I will disable automatic selection only for default subtitle tracks if system captioning preferences are turned off. This should make it work just like YouTube. Forced subtitles will still be always selected.

VasilisKos commented 1 year ago

@VasilisKos I will disable automatic selection only for default subtitle tracks if system captioning preferences are turned off. This should make it work just like YouTube. Forced subtitles will still be always selected.

I think it'll be even better, if only the subs of the language that is chosen as default in the app settings are loaded automatically.