search

mongkuen / gatsby-plugin-eslint

Gatsby plugin to add support for ESLint
MIT License
13 stars 14 forks source link

fix: Set correct peerDependency on gatsby #29

Closed LekoArts closed 3 years ago

LekoArts commented 3 years ago

Hello @mongkuen, Gatsby maintainer here 👋 First and foremost, thanks for creating the plugin & maintaining it. Much appreciated!

While looking at your plugin I noticed that the peerDependency on gatsby is set incorrectly. We're in the process of providing more helpful information on the /plugins page of our website and for that we need plugins to set their peerDependencies correctly/more specific.

At the moment you say that any version (v3, v4, v5, v6, etc.) will work with this even when in between we'd introduce breaking changes.

Making it more explicit is the safer choice (in the future you'll be able to mark breaking changes with explicit version ranges) and will allow us to display the plugin as compatible to versions X, Y, Z.

Thanks!

pragmaticpat commented 3 years ago

Hi @mongkuen - do you have any questions on this PR? We're wondering if you'd be so kind as to merge it in, thereby helping users of this plugin to have the correct peer dependencies. Thank you! 💜

pragmaticpat commented 3 years ago

Thanks @mongkuen !