search

mongo-express / mongo-express-docker

a dockerized mongo-express for viewing mongoDB in the browser
MIT License
201 stars 93 forks source link

Update to Node.js 12 (8 is EOL, 12 is LTS) #40

Closed tianon closed 4 years ago

tianon commented 4 years ago

Also, this updates update.sh to no longer use Docker and instead query "registry.npmjs.org" directly (which is much faster).

I did not update the actual version number here since I'd like to make sure I've got something to test @docker-library-bot integration with. :sweat_smile:

I did however test this against https://github.com/docker-library/official-images/pull/5697 successfully. :+1:

(Without this, ./generate-stackbrew-library.sh fails because node:8-alpine isn't supported anymore.)

tianon commented 4 years ago

I chose 12 because both 10 and 12 are LTS and 12 should stay LTS longer than 10 will (and the package.json for mongo-express itself specifies only 6+: https://github.com/mongo-express/mongo-express/blob/5b9b34f8553d004ceb7b666bbf566b406a2a3153/package.json#L83).

knickers commented 4 years ago

Holy cow you make changes faster than I can even respond to your suggestions :laughing:

Thank you. This looks good to me :+1:

tianon commented 4 years ago

I've got a few extra minutes tonight and would love to see mongo-express get updated before the weekend! :smile: :innocent:

tianon commented 4 years ago

Hah, and now I realize the generate-stackbrew-library.sh script I've got is a local one, not something from this repository. Expect a follow-up in a minute. :see_no_evil: :speak_no_evil:

(https://doi-janky.infosiftr.net/job/update.sh/job/mongo-express/1/console)

knickers commented 4 years ago

doi-janky :rofl: What an awesome name!