Change RUN command to use yarn

mongo-express / mongo-express-docker

a dockerized mongo-express for viewing mongoDB in the browser

MIT License

201 stars 93 forks source link

Change RUN command to use yarn #85

Closed rtritto closed 2 years ago

rtritto commented 2 years ago

Changes:

replace the install of mongo-expres with yarn
replace && with ; (source)

Open points:

I didn't included --virtual .me-install-deps option. Do we need it?

FYI @MahdiAbbasi95

BlackthornYugen commented 2 years ago

I feel like me deps is required still. I tried removing it before and I think it builds but breaks something at runtime? Does me deps install tiny?

rtritto commented 2 years ago

I built and started with no problems. .me-install-deps is the name of custom packages using --virtual (source). I don't think that it's really needed (it can be added on bash/tini install command).

MahdiAbbasi95 commented 2 years ago

Changes:

replace the install of mongo-expres with yarn

replace && with ; (source)

Open points:

I didn't included --virtual .me-install-deps option. Do we need it?

FYI @MahdiAbbasi95

Actually we don’t need to the virtual option anymore, in the old Dockerfile it used to adding some temporary packages and remove at the end, but in the current Dockerfile we don’t need to this feature.