Added multi-variant support

mongo-express / mongo-express-docker

a dockerized mongo-express for viewing mongoDB in the browser

MIT License

198 stars 93 forks source link

Added multi-variant support #93

Closed LaurentGoderre closed 9 months ago

LaurentGoderre commented 9 months ago

TODO

[x] Update the stackbrew script
[x] Reimplement version update script for multi-variant

LaurentGoderre commented 9 months ago

Result of the new bashbrew script

Maintainers: Nick Cox <nickcox1008@gmail.com> (@knickers)
GitRepo: https://github.com/mongo-express/mongo-express-docker.git
GitCommit: f0d9157c39653e52f5434455592f23ac0e9c0c8c
Tags: 1.0.0, 1.0, 1, latest, 1.0.0-18, 1.0-18, 1-18, 18, 1.0.0-18-alpine3.17, 1.0-18-alpine3.17, 1-18-alpine3.17, 
Architectures: amd64, arm64v8
GitCommit: c3cebea3955f4815c01c2a6fd2a966a4296f9760
Directory: 1.0/18-alpine3.17
Tags: 1.0.0-18-alpine3.18, 1.0-18-alpine3.18, 1-18-alpine3.18, 
Architectures: amd64, arm64v8
GitCommit: c3cebea3955f4815c01c2a6fd2a966a4296f9760
Directory: 1.0/18-alpine3.18
Tags: 1.0.0-20, 1.0-20, 1-20, 20, 1.0.0-20-alpine3.17, 1.0-20-alpine3.17, 1-20-alpine3.17, 
Architectures: amd64, arm64v8
GitCommit: c3cebea3955f4815c01c2a6fd2a966a4296f9760
Directory: 1.0/20-alpine3.17
Tags: 1.0.0-20-alpine3.18, 1.0-20-alpine3.18, 1-20-alpine3.18, 
Architectures: amd64, arm64v8
GitCommit: c3cebea3955f4815c01c2a6fd2a966a4296f9760
Directory: 1.0/20-alpine3.18

LaurentGoderre commented 9 months ago

@BlackthornYugen let me know if you want me to demo the new scripts

BlackthornYugen commented 9 months ago

That'd be great! Would you be free for a call on discord or something this weekend?

LaurentGoderre commented 9 months ago

@BlackthornYugen what is your availability? Im usually free after the kjds are in bed (I noticed we are in the samer timezone)

BlackthornYugen commented 9 months ago

@BlackthornYugen what is your availability? Im usually free after the kjds are in bed (I noticed we are in the samer timezone)

I should have some time Saturday morning or maybe Sunday evening. I might be able to do something later this evening if that works.

LaurentGoderre commented 9 months ago

I can tonight after 10 if it's not too late. It wouldn't be very long

BlackthornYugen commented 9 months ago

I can tonight after 10 if it's not too late. It wouldn't be very long

That should work. 🙂

BlackthornYugen commented 9 months ago

@LaurentGoderre thanks for the demo. Looks great! As discussed you said you would be able to make one more change on Monday and then we can merge. 😄

LaurentGoderre commented 9 months ago

Yes, I have to figure out why the variant list is duplicated in some versions

LaurentGoderre commented 9 months ago

@BlackthornYugen this is ready for final review.

LaurentGoderre commented 9 months ago

Is it ok we add it to a CONTRIBUTING.md instead of readme like here https://github.com/nodejs/docker-node/blob/main/CONTRIBUTING.md.

BlackthornYugen commented 9 months ago

Is it ok we add it to a CONTRIBUTING.md instead of readme like here https://github.com/nodejs/docker-node/blob/main/CONTRIBUTING.md.

That'd be great! Just wanted to make sure it was documented somewhere.

LaurentGoderre commented 9 months ago

@BlackthornYugen https://github.com/mongo-express/mongo-express-docker/pull/93/files?short_path=eca12c0#diff-eca12c0a30e25b4b46522ebf89465a03ba72a03f540796c979137931d8f92055