search

mongo-express / mongo-express-docker

a dockerized mongo-express for viewing mongoDB in the browser
MIT License
198 stars 93 forks source link

Yarn error while building image in Node 18 and 20 #97

Closed LaurentGoderre closed 5 months ago

LaurentGoderre commented 9 months ago

Error is

error Couldn't find any versions for "mongodb-query-parser" that matches "patch:mongodb-query-parser@npm%3A2.4.6#~/.yarn/patches/mongodb-query-parser-npm-2.4.6-234abad2fc.patch"
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
LaurentGoderre commented 9 months ago

This will only apply to 1.01. 1.0.0 seems to work fine

rtritto commented 9 months ago

This issue is fixed in https://github.com/mongo-express/mongo-express/pull/1136 (related: https://github.com/mongo-express/mongo-express/issues/1162). Current Dockerfile build uses mongo-express from npm package, so an update of npm version will fix this issue.

PS: maybe we should consider to build from master branch of mongo-express (related: https://github.com/mongo-express/mongo-express-docker/pull/82#issuecomment-1249563687).

LaurentGoderre commented 9 months ago

Building from master isn't ideal as far as Docker image go because there are no way to pin to a point in time.

rtritto commented 9 months ago

Building from master isn't ideal as far as Docker image go because there are no way to pin to a point in time.

You're right, we should use instead the branch of version tag (i.g.: https://github.com/mongo-express/mongo-express-docker/tree/<VERSION_TAG>).

BlackthornYugen commented 9 months ago

I think it would be good to eventually do the builds from the mongo-express/mongo-express repo, a lot of people have found having dockerfiles in both repos confusing (including me when I first found mongo express) :)

BlackthornYugen commented 5 months ago

We worked around this last week by building from the release branch of mongo-express.