search

mongodb-js / boxednode

📦 boxednode – Ship a JS file with Node.js in a box
Apache License 2.0
599 stars 10 forks source link

Binary build with nodejs lts (v14.15.3) fails on Windows #12

Closed asamuzaK closed 3 years ago

asamuzaK commented 3 years ago

Build fails when creating a binary with nodejs lts (currently v14.15.3) on Windows.

Job log

The build was successful until v14.15.1. There seems to be some fixes in vcbuild.bat between v14.15.1 and v14.15.3.

Comparing v14.15.1...v14.15.3 · nodejs/node

addaleax commented 3 years ago

I could not reproduce this locally -- I've opened https://github.com/mongodb-js/boxednode/pull/13, if this is something that's specific to github actions, it might let us know.

asamuzaK commented 3 years ago

After many failures, I was finally able to build it successfully. Job log

I was using bash on Windows as well in my github workflow, but when I changed shell to cmd, it worked. I don't know why it used to succeed with bash before and now it doesn't, but anyway, I will close this issue as invalid.

Thanks

addaleax commented 3 years ago

@asamuzaK I know it's been a few months, but I finally figured out the underlying cause here. #17 should fix this for all environments.

asamuzaK commented 3 years ago

Thank you for the information. I will test with the new version and let you know the result. Maybe this weekend.

asamuzaK commented 3 years ago

Verified. Job log