mongodb-js / boxednode

📦 boxednode – Ship a JS file with Node.js in a box
Apache License 2.0
599 stars 10 forks source link

feat: allow JSON in `BOXEDNODE_{CONFIGURE,MAKE}_ARGS` #27

Closed addaleax closed 2 years ago

addaleax commented 2 years ago

In mongosh, we introduced NODE_JS_CONFIGURE_ARGS (not remembering that boxednode already provides this capability). We should just use a single consistent env var throughout the build process.

This adds JSON array support for these environment variables for cases in which the list items themselves contain commas, and, as a drive-by fix, avoids mutating the input options argument.