feat:CHARTS-3806 Update Readme to use new Unauthenticated sample

mongodb-js / charts-embed-sdk

The easiest way to embed MongoDB Charts visualisations into your web app

https://docs.mongodb.com/charts/master/embedding-charts-sdk/

Apache License 2.0

43 stars 31 forks source link

feat:CHARTS-3806 Update Readme to use new Unauthenticated sample #4

Closed andym03 closed 4 years ago

andym03 commented 4 years ago

Used the new unauthenticated sample in the preview gif of the Embedded SDK. Might be harder to read though, so in this case i'm cool with keeping the old one, just thought i'd preview it :)

scottsidwell commented 4 years ago

Thanks for raising! I'm not opposed to using your fancy new sample - but I think the gif you've raised is too wide.

If you wanted to replace the existing one, I'd suggest:

making sure it look good at ~600x450px, or thereabouts
add a 2px dark-gray border to your sample, and crop around it. 1) this just makes your life trying to crop the GIF much easier 2) the background color change is less surprising to users when viewing the docs since they're aware of the 'bounds' of the GIF

scottsidwell commented 4 years ago

Love your work. Care to raise a PR against the Charts monorepo to update the NPM readme with this as well?