search

mongodb-js / devtools-shared

Shared dependencies of Compass, the MongoDB extension for VSCode and mongosh
Other
14 stars 5 forks source link

fix(shell-bson-parser): Support `valueOf` date method #478

Closed benleembruggen closed 2 weeks ago

benleembruggen commented 3 weeks ago

Description

Adds support for the valueOf Date method to the shell-bson-parser package

Checklist

mongo-J commented 3 weeks ago

Hi @mcasimir, do you know by any chance that what is the process of releasing the patch for the package or is it fully automated once pr is merged. And if there is any requirement for documentation? Also the PR checklist has a contributor license agreement does @benleembruggen need to sign this? TIA!

Anemy commented 3 weeks ago

@mongo-J

what is the process of releasing the patch for the package

It's fully automated when a pr is merged. We should probably add a bit of documentation for that. I'll open a pr. The versioning (patch/minor/major) happens depending on the commit message. It uses conventional commits: https://www.conventionalcommits.org/en/v1.0.0/ This pr looks fine as is though, it will be a minor bump when merged. Let me know if you'd like me to merge it in, not sure if you have permissions.

And if there is any requirement for documentation

We don't keep changelogs for these packages, so no. If it's a breaking change or needs a migration then it can be good to add that to a README somewhere or add a changelog describing it. In that case we also would want a major version bump, which can be indicated through a !. https://www.conventionalcommits.org/en/v1.0.0/

Also the PR checklist has a contributor license agreement does @benleembruggen need to sign this?

If they are a MongoDB employee no.

The code behind bumping packages if curious: https://github.com/mongodb-js/devtools-shared/blob/main/packages/monorepo-tools/src/bump-packages.ts