search

mongodb-js / devtools-shared

Shared dependencies of Compass, the MongoDB extension for VSCode and mongosh
Other
14 stars 5 forks source link

fix: Suppress node 23 warnings about require-ing ESM MONGOSH-1895 #488

Closed nirinchev closed 1 week ago

nirinchev commented 1 week ago

Description

Starting with node 23, support for require-ing ES modules no longer throws but instead prints a warning in the output. This is problematic for homebrew users since homebrew aggressively upgrades node, regardless of what the preferred node version is for a package. This PR takes one approach, which is to suppress experimental warnings altogether for Node 23. This is only manually tested since I'm not convinced it's the approach we'd like to take (see Open Questions) - once we've settled on it, I'll need to figure out a way to test.

Open Questions

This feels a bit hacky and I'm not convinced this is the long term fix we'd like to use. Here are a few alternatives, ranked from easy to hard:

  1. We could try and more narrowly suppress the specific require() warning.
  2. We could restore the original warning emitter after importing fetch.
  3. We could change moduleResolution to NodeNext and fix the issues that this causes (unfortunately, I wan't able to trace what they were).
  4. We could migrate to ES modules.

Checklist

nirinchev commented 1 week ago

Closing in favor of https://github.com/mongodb-js/mongosh/pull/2258.