search

mongodb-js / electron-squirrel-startup

Default Squirrel.Windows event handler for your Electron apps.
Apache License 2.0
217 stars 41 forks source link

Updated require for electron app. #3

Closed Vj3k0 closed 8 years ago

Vj3k0 commented 8 years ago

Fixing failure with electron 1.0.0

This change is Reviewable

mention-bot commented 8 years ago

By analyzing the blame information on this pull request, we identified @imlucas and @kangas to be potential reviewers

Vj3k0 commented 8 years ago

Really? Hmm, I got electron error saying that it is not valid electron application. When I did this change, everything worked. Which version of electron did you use?

mitchhentges commented 8 years ago

Confirmed, also not working for me unless this PR is merged. Seems to be related to Electron 1.0.0+ removing deprecated usage, and app has to be pulled off of require('electron'), now, instead of in it's own require('app').

See the docs here

jbleuzen commented 8 years ago

@Vj3k0 I was meaning that your fork was working. I'm using it until it's merged...

develar commented 8 years ago

@imlucas Please apply this PR ASAP, because your module is recommended by electron-builder/windows-installeer and widely used. Please accept PR.

mitchhentges commented 8 years ago

Hey all, I've forked this to support electron@^1.0.0, and published the fork to npm under the name electric-squirrel.

Thanks again to Vj3k0 for the fix! See the details here

aaleks commented 8 years ago

+1

develar commented 8 years ago

@imlucas If you don't have time, just add me to contributor (+ npm) (I maintainer of electron-builder, so, unlikely I will harm ;)) I really don't want to reinvent the wheel and promote @mitchhentges fork :)

In the future will be cool to move this project to electron-userland org.

develar commented 8 years ago

BTW electron-builder has own fork of Squirrel.Windows, so, in the future, https://github.com/electron-userland/electron-builder/issues/409 may be implemented, and such module will be not required (yeah, so easy to create os x app, and so many troubles under windows...).

imlucas commented 8 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

imlucas commented 8 years ago

published in electron-squirrel-startup@0.2.0

develar commented 8 years ago

@imlucas Thanks! Maybe it is time to publish it as 1.0.0? Because ^0.1.0 will not cover 0.2. I think there are no planned breaking changes and, so, 1.0.0 can be used.

imlucas commented 8 years ago

@develar agreed. published electron-squirrel-startup@1.0.0

imlucas commented 8 years ago

@develar added as a contributor

Vj3k0 commented 8 years ago

Thanks a lot! Cheers