search

mongodb-js / is-mongodb-running

Is MongoDB running? What port is it using?
Apache License 2.0
3 stars 3 forks source link

Add support for Promises in module #11

Closed addisonElliott closed 6 years ago

addisonElliott commented 6 years ago

Uses util.promisify built into Node v8 to create a Promise from the is-mongodb-running function.

These changes are backwards compatible with the current callback style function. If the Promise-style function is desired, simple require('is-mongodb-running/promise') to get the promisified function instead.

Updated the is-mongodb-running binary to use promises. Code looks a bit cleaner.

Travis CI errors are unrelated to the PR. Issues are fixed in #9.

Resolves issue #5.

Note: @imlucas What do you think about this method? It doesn't break compatibility and it allows the use of promises. Personally, I'm on the fence about this because the util.promisify function could be called upon importing the module. Thus, the question is whether it is something the library should support.

addisonElliott commented 6 years ago

cc: @imlucas

Do you mind looking at these when you get a chance, please?

imlucas commented 6 years ago

Sweet! Apologies again for the delay and thanks so much @addisonElliott!