first stab at `mj install`

[rueckstiess]

current progress

mj install will

• run npm install -g jshint (requirement for SublimeLinter-jshint)

and additionally, if --sublime supplied, search for sublime installation to

• register several plugins with Package Control (if installed): Jade, LESS, jsfmt, SublimeLinter, SublimeLinter-jshint, Git
• hide dot (.*) files via User preferences setting

[imlucas]

Comments from the review on Reviewable.io

Reviewed files:

• commands/demo.js @ r1

---

^{commands/install.js, line 132 [r1] (raw file):} If already installed, npm install will just be a noop so don't worry

---

^{package.json, line 18 [r1] (raw file):} Why all of lodash when you're just using amp-each and amp-has?

---

^{test/index.test.js, line 95 [r1] (raw file):} Use if(err) return cb(err); or assert.ifError(err); instead

---

^{test/index.test.js, line 106 [r1] (raw file):} Use if(err) return cb(err); or assert.ifError(err); instead

---

^{util/run_steps.js, line 9 [r1] (raw file):} If we're going to use jsdocs, let's use them everywhere and format properly https://www.npmjs.com/package/dox

---

[imlucas]

Comments from the review on Reviewable.io

Reviewed files:

• commands/check.js @ r1
• commands/install.js @ r1
• docopts/create.docopt @ r1
• docopts/demo.docopt @ r1
• docopts/help.docopt @ r1
• docopts/install.docopt @ r1
• package.json @ r1
• test/index.test.js @ r1
• util/run_steps.js @ r1
• util/symbols.js @ r1

---

[imlucas]

Comments from the review on Reviewable.io

---

Looking good. Just a few questions I'm curious about.

---

[rueckstiess]

Comments from the review on Reviewable.io

---

^{commands/install.js, line 132 [r1] (raw file):} I know but it takes 3-5 seconds. Would be nice if it was instant.

---

^{package.json, line 18 [r1] (raw file):} good point, will replace with amp-*.

---

[imlucas]

Comments from the review on Reviewable.io

---

^{commands/install.js, line 132 [r1] (raw file):} Ah I see. Comment made me think you needed for sanity. This will cut it down to ~500ms:

var exec = require('child_process').exec;

/**
 * Check if a module with `name` is installed globally.
 *
 * @param {String} name of the module, e.g. jshint
 * @param {Function} fn (error, exists)
 */
function isModuleInstalledGlobally(name, fn){
  var cmd = 'npm ls --global --production --json --depth=0';
  exec(cmd, function(err, stdout){
    if(err) return fn(err);

    var data = JSON.parse(stdout);
    var installed = data.dependencies[name];
    fn(null, (installed !== undefined));
  });
}
// npm install pretty-hrtime
var prettyHrtime = require('pretty-hrtime');
var start = process.hrtime();
isModuleInstalledGlobally('jshint', function(err, installed){
  var duration = process.hrtime(start);
  console.log('exec of npm ls took', prettyHrtime(duration));

  if(err) return console.error(err);
  console.log('jshint installed globally?', installed);
});

---

[imlucas]

Comments from the review on Reviewable.io

Reviewed files:

• commands/install.js @ r2
• package.json @ r2
• test/index.test.js @ r2
• util/run_steps.js @ r2

---

[imlucas]

Comments from the review on Reviewable.io

---

:thumbsup:

---

[rueckstiess]

Comments from the review on Reviewable.io

---

^{commands/install.js, line 132 [r1] (raw file):} Perfect, thanks! --json is great.

Replacing and merging in PR.

---