search

mongodb-js / mongodb-prebuilt

Install MongoDB prebuilt package using npm https://npmjs.org/package/mongodb-prebuilt
ISC License
56 stars 50 forks source link

always call the callback and return #27

Closed pibi closed 7 years ago

pibi commented 8 years ago

Fix for #12

Amri91 commented 8 years ago

@pibi, I tested the new code and I am still getting the issue mccormicka/Mockgoose#204.

Do we not need to use something like this?

if(typeof(callback) == "function"){
            callback(child.status);
}

at the end?

brandon-arnold commented 8 years ago

I also required the conditional described by @Amri91. I'm on Windows 10.

My build of MERN is broken without this. When will it get merged?

winfinit commented 7 years ago

there was a rewrite of this library, so I am closing this pull request.