mongodb-js / mongodb-prebuilt

Install MongoDB prebuilt package using npm https://npmjs.org/package/mongodb-prebuilt
ISC License
56 stars 50 forks source link

Fix: Ensure that starting server under Windows through Mockgoose does not … #32

Closed xaveng closed 7 years ago

xaveng commented 8 years ago

based on: https://github.com/admin-ch/mongodb-prebuilt/commit/cad20d7ba06cce4355edb1faf5b5c3c5b41f1b84

We cannot get child.status when running on Windows system. Since ChildProcess object does not have status property. Look ChildProcess((https://nodejs.org/api/child_process.html#child_process_child_process), spawn(https://nodejs.org/api/child_process.html#child_process_child_process_spawnsync_command_args_options) However in this way, we cannot be sure that mongod is correctly called on Windows...

winfinit commented 7 years ago

this is out of date now, sorry for being unresponsive, but I was planning a rewrite that is completed now, so previously reported issues should be resolved now. Thank you for this pull request, and for supporting this project