mongodb-js / mongodb-prebuilt

Install MongoDB prebuilt package using npm https://npmjs.org/package/mongodb-prebuilt
ISC License
56 stars 50 forks source link

Add ability to control mongo download #51

Closed xscheiner closed 5 years ago

xscheiner commented 6 years ago

We needed to be able to download a specific version of mongo to run our tests. So we added the ability to pass in options that go to the mongodb-download package. We've tested that this runs cleanly in the default mode as well as with the options.

We also added some scripts for linting and building in package.json. We left in the fix option on the linting which has added a lot of spacing and formatting changes. Apologies for that.

Fixes #50 Fixes #42

LoneRifle commented 5 years ago

Apologies, but could I have you redo this PR so that the linting and actual changes are in separate commits?

xscheiner commented 5 years ago

Sorry, I didn't see the notifications on these messages and I left you with a bit of extra work. Is it all sorted now?

LoneRifle commented 5 years ago

Yes it is - published as 6.4.0. I had to force-push into your branch as part of the work done, sorry about that