search

mongodb-labs / drivers-evergreen-tools

Scripts for MongoDB drivers to bootstrap their Evergreen configuration file - This Repository is NOT a supported MongoDB product
10 stars 64 forks source link

RUST-2035 Fix invocation of mongosh for requireApiVersion #497

Closed abr-egn closed 1 month ago

abr-egn commented 1 month ago

RUST-2035

Example failing run and passing run against my fork with the fix.

I'm honestly not sure how this worked before; mongosh is moved into the $MONGODB_BINARIES path by the install script and isn't in $PATH.

blink1073 commented 1 month ago

What if we instead add to to PATH here? https://github.com/mongodb-labs/drivers-evergreen-tools/blob/4ff62cd75cdebe4ce166fe0003e364eaa310fb0e/.evergreen/handle-paths.sh#L56

blink1073 commented 1 month ago

I can follow up with a PR with a REQUIRE_API_VERSION test in drivers-tools as well. I'll also need to add a test for invoking download-mongodb.sh directly to cover @eramongodb's case as well.

abr-egn commented 1 month ago

What if we instead add to to PATH here?

https://github.com/mongodb-labs/drivers-evergreen-tools/blob/4ff62cd75cdebe4ce166fe0003e364eaa310fb0e/.evergreen/handle-paths.sh#L56

That would work as well, but I'm generally more a fan of keeping state explicit 🙂 It's also more consistent with how mongosh is called from other scripts in this repo.

blink1073 commented 1 month ago

test-oidc-k8s-local is a known flakey test.