mongodb-labs / drivers-evergreen-tools

Scripts for MongoDB drivers to bootstrap their Evergreen configuration file - This Repository is NOT a supported MongoDB product
10 stars 64 forks source link

Fix path handling in download-mongodb #498

Closed blink1073 closed 1 month ago

blink1073 commented 1 month ago

I tested this by cloning the c driver and invoking the integration script. The way that script gets invoked is pretty gnarly and unexpected. The path ends up being .evergreen/scripts/../../drivers-evergreen-tools/.evergreen/download-mongodb.sh, and I'm not sure how to get that into a suitable path. I'll have to follow up with a more robust solution.

blink1073 commented 1 month ago

Worst case I'll follow up with an inline retry function because we're already seeing a failure with:

curl: (92) HTTP/2 stream 1 was not closed cleanly: INTERNAL_ERROR (err 2)
Error: Process completed with exit code 92.
blink1073 commented 1 month ago

test-oidc-k8s-local failure is expected, I had to tear down the cluster today

ShaneHarvey commented 1 month ago

We previously used curl's built in retries but not all curls we use are new enough because we test on so many different/old hosts. See PYTHON-3721 and DRIVERS-2625.

blink1073 commented 1 month ago

Updated to restore curl_retry. I'll make sure to test the c driver if changing this file in the future.