search

mongodb-labs / edda

A log visualizer for MongoDB - This Repository is NOT a supported MongoDB product
232 stars 28 forks source link

[cleanup] filters/ #63

Closed kchodorow closed 12 years ago

kchodorow commented 12 years ago

I mentioned some of these things in code reviews, I'm not thrilled about having to point them out again:

  1. Is this needed? https://github.com/kchodorow/logl/blob/master/logl/filters/conn_msg.py#L20-21
  2. Get rid of this check: https://github.com/kchodorow/logl/blob/master/logl/filters/fsync_lock.py#L28, conn has nothing to do with the messages you're looking for
  3. "starting" is not specific enough to determine if this is a startup message: https://github.com/kchodorow/logl/blob/master/logl/filters/init_and_listen.py#L28
  4. Ditto on these strings. They need to be longer, match more. https://github.com/kchodorow/logl/blob/master/logl/filters/rs_exit.py#L24-29
  5. Ditto here: https://github.com/kchodorow/logl/blob/master/logl/filters/rs_exit.py#L24-25, should 1 string like "[rsSync] replSet syncing to: ". Same kind of thing for the strings in 3 & 4, ask if you need help with figuring out what they should be.
  6. Do not call https://github.com/kchodorow/logl/blob/master/logl/filters/rs_sync.py#L65 reSyncing. reSyncing means something else. syncingFrom, syncTarget, or rsSync would all be fine.

Please feel free to ask for clarification if it doesn't make sense to you why these need to be fixed.

kaushal commented 12 years ago

Numbers 1-4 are complete.