Closed Liyixin95 closed 10 months ago
Hi @Liyixin95, thanks for running these benchmarks! Would you be interested in making a PR to switch over to one of the libraries you profiled? We don't currently have the bandwidth to do this but would be happy to review it. We'd also want to run these benchmarks on our machines to ensure that these performance improvements can be reproduced. Otherwise I can file a ticket to consider doing this in the future.
There has not been any recent activity on this ticket, so we are marking it as stale. If we do not hear anything further from you, this issue will be automatically closed in one week.
There has not been any recent activity on this ticket, so we are closing it. Thanks for reaching out and please feel free to file a new issue if you have further questions.
benchmark env
benchmark suit
benchmark suit
id: 10, 12, 14
my computer
windows11 13th Gen Intel(R) Core(TM) i7-13700H 32.0 GB 3200 MHz
benchmark result
original
bstr
bstr need to be pinned to
<1.7.0
to satisfy the msrv requirment.simdutf8
simdutf8 does not support
from_utf8_lossy
, so only lossless transformation was optimized.conclusion
bstr
looks like slower thensimdutf8
in my computer, may be because they do not supportavx2
. So, I tend to usesimdutf8
to optimize utf8 validation. But the final decision is depending on your teams.