CLOUDP-169104: Fix encoding for AWS IAM usernames - Githubissues

mongodb / go-client-mongodb-atlas

Go Client for MongoDB Atlas

https://www.mongodb.com/docs/atlas/reference/api-resources-spec/

Apache License 2.0

79 stars 34 forks source link

CLOUDP-169104: Fix encoding for AWS IAM usernames #452

Closed andmatei closed 1 year ago

andmatei commented 1 year ago

Description

As per the old docs:

AWS IAM usernames include characters which must be URL encoded. Replace all : characters with %3A. Replace all / characters with %2F.

https://www.mongodb.com/docs/atlas/reference/api/database-users-get-single-user/#example-request

Using url.PathEscape would only encode / characters, while url.QueryEscape encode both : and /

Link to any related issue(s): https://github.com/mongodb/mongodb-atlas-cli/issues/1817

Type of change:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Required Checklist:

[x] I have signed the MongoDB CLA
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added any necessary documentation (if appropriate)
[x] I have run make fmt and formatted my code

andmatei commented 1 year ago

This will also be a problem with the autogenerated SDK - left more comments on the ticket