CLOUDP-227413: AKO templates

mongodb / helm-charts

Apache License 2.0

99 stars 92 forks source link

CLOUDP-227413: AKO templates #348

Closed igor-karpukhin closed 1 month ago

igor-karpukhin commented 1 month ago

All Submissions:

Added two new helm charts showcasing basic and advanced configurations

[ ] Have you opened an Issue before filing this PR?
[x] Have you signed our CLA?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

s-urbaniak commented 1 month ago

Is there any way helm supports some form of unit testing? Was this tested manually?

josvazg commented 1 month ago

Is there any way helm supports some form of unit testing? Was this tested manually?

https://helm.sh/docs/topics/chart_tests/ maybe? but that is not a unit test per se.

Other than that, when working manually you can tell helm to spit out the YAMl without applying with helm template, so that you can inspect it is producing what you expected.

igor-karpukhin commented 1 month ago

Is there any way helm supports some form of unit testing? Was this tested manually?

Yes, there is a way to add basic "template generating" tests and compare the result to the expected values. Our charts do not have tests for now. So I tested both manually.

s-urbaniak commented 1 month ago

Our charts do not have tests for now. So I tested both manually.

I think this is worth a ticket and something we'd want to tackle as part of product quality maturity, would you mind creating one?

@igor-karpukhin Besides: couldn't we add an integration test in AKO at least, similar to what we do now? This would require this PR to merge first.

igor-karpukhin commented 1 month ago

Do not have extra comments on top of @s-urbaniak The code and the expanded default templates look good. Have these been tested in Cloud QA?

Yes, as I said, both charts were tested on cloudqa