search

mongodb / laravel-mongodb

A MongoDB based Eloquent model and Query builder for Laravel (Moloquent)
https://www.mongodb.com/docs/drivers/php/laravel-mongodb/
MIT License
7.02k stars 1.43k forks source link

Proposal about new maintainers #1892

Closed Smolevich closed 4 years ago

Smolevich commented 4 years ago

@jenssegers, library has pending PR's waiting review one month and more, old docs, broken ci in travis, many issues without answers for community. I propose to find new maintainers from community, if you don't have enough time to maintance this library. Any can fork and improve separately but I think that community can improve this library if maintainers will have enough time for maintance.

With regards, Smolevich

Smolevich commented 4 years ago

Fixed failed ci https://github.com/jenssegers/laravel-mongodb/pull/1893

brandon-braner commented 4 years ago

I would be more than happy to volunteer to help maintain this project. I am just starting to use it however I was also a bit concerned about the number of open issues and pull requests. It makes me feel uneasy about using it in a production system.

Does anyone know how to get a hold of the owner? If they are not checking issues not sure this will ever get seen.

jenssegers commented 4 years ago

Hi @brandon-braner, shall we set up a skype call to discuss this?

brandon-braner commented 4 years ago

@jenssegers I would love to. Can I email you at hello@jenssegers.com? Grabbed that from your Github profile.

Smolevich commented 4 years ago

@brandon-braner, @jenssegers can we discuss together, in slack or email?

Smolevich commented 4 years ago

@brandon-braner, here link on existing slack community

divine commented 4 years ago

@jenssegers well, first of thank you for the work that you've done.

We can understand that this is open source and you're not paid for this, however the fact that you're simply ignoring pull requests from other contributors makes everyone sad and unhappy while using this library in a project.

If you don't have a time, please kindly archive this repo and give a chance to somebody else/some other library or just add some information to readme that this library reviewing pull requests in ~4 months and there are so many bugs/issues - use at your own risk.

Thank you!

rennokki commented 4 years ago

I stopped waiting for the updates and jumped and improved it in my fork: https://github.com/rennokki/laravel-mongodb

PRs are welcomed :)

Smolevich commented 4 years ago

@rennokki i propose to wait answer from @jenssegers. Are you single maintainer of your fork? Do you have plans on improvement library ? How many time do you spend on library?

rennokki commented 4 years ago

I use mongo actively on some production workloads on my day-to-day job and side projects, and sometimes custom implementations are not unusual, and the times to wait for an update is killing the productivity, that's why I forked the repo. Currently, I am the only one, but I can actively select some in the case it is needed.

divine commented 4 years ago

@Smolevich @rennokki well, if we're a looking for a new fork some issues needs to be fixed and reworked.

Current implementation is a bit hacky, probably best would to remove mysql support and use doctrine mongodb.

There is already an implemented integration but it's not updated since 2017.

rennokki commented 4 years ago

I have searched for issues throughout the Issues board and the addressed PRs, but i found some that are old and i didn't find any real reason why they should be merged.

The broken CI also freaked me because having several production workloads and using a package that continues to merge the PRs without having the CI check is risky.

Smolevich commented 4 years ago

@rennokki PR with support GA was merged, problem with failed travis ci was fixed, so all new PR's are checked

@rennokki do you want to help with maintenance this library ? As i can see you improve you fork but we (@jenssegers , @brandon-braner and I) can come together to support an improve this library but before we discuss about future plans on this library I propose each ask on some questions if someone want to become maintainer of this library:

  1. What is your experience as a maintainer of some library or framework? Maybe links on projects on github
  2. How many hours are you ready spent on supporting this library?
  3. Who uses this library in production ?
rennokki commented 4 years ago

Not much in open source - i really implemented packages across several Laravel apps in private repos at my day-to-day job which sticks with Laravel/Lumen for 2+ years. I check github daily on issues, so that's what made me tryna gather more ppl to PR their problems and fix them in a separate package.

I don't mind maintaining this library at all. I also use it in production on several projects.

divine commented 4 years ago

Well, I'm really happy this isn't new fork and we're all here now. Previously something like this already happened (see dead fork which isn't maintained anymore https://github.com/moloquent/moloquent).

@jenssegers I kindly ask you (or just my personal suggestion), please add new maintainers who are ready to help out, everyone will be just happy and issues will be fixed instantly!

@Smolevich thank you for taking care!

Thank you!

rennokki commented 4 years ago

@Smolevich mail me the slack if there's any

Smolevich commented 4 years ago

@rennokki, Alex Renoki is it your nickname in slack for this library?

Smolevich commented 4 years ago

@jenssegers add new some contributors. Thanks for reaction, Jens. I propose to do next tasks as soon possible :

  1. collect bugs in last issues
  2. Add https://github.com/apps/stale for check new issues
  3. Add templates for issues Docs Link to issue https://github.com/jenssegers/laravel-mongodb/issues/1912
  4. Close old and not actual issues and PR's
divine commented 4 years ago

@jenssegers add new some contributors.

That's sound great 👍 . Thank you @jenssegers!

3. Add templates for issues () Docs Link to issue #1912

I might take care as well.

  1. Close old and not actual issues and PR's

I'm currently checking each PR's if it was already merged/fixed, it takes time.

Giacomo92 commented 4 years ago

@Smolevich 5 Add a static site docs. The README is too long. So I think we can improve searchability and add more examples. We can use vuepress. It is very simple (markdown syntax) and it can be deployed on Github Pages.

rennokki commented 4 years ago

@Giacomo92 i think that would be too complicated, maybe having a short and concise docs would be better. It's about the quality not the quantity.

rennokki commented 4 years ago

StyleCI and CodeCov/Codacy can be a good start too.

Smolevich commented 4 years ago

I propose to add any ideas here https://github.com/jenssegers/laravel-mongodb/issues/1914

Giacomo92 commented 4 years ago

@Giacomo92 i think that would be too complicated, maybe having a short and concise docs would be better. It's about the quality not the quantity. @rennokki Complicated? Why ? It is a simple markdown file. You do not need to know anything else. A docs site is more readable and maintainable. Every package has a site, see Spatie Docs