[Bug fix] Fix BelongToMany when using ObjectId in relation

[florianJacques]

When we use mongodb ObjectIDs for relationships In the case of a BelongToMany relation, the foreignKeys was incorrectly cast

{
    "_id" : ObjectId("667e831289f74871500d80a7"),
    "name" : "Jean-Luc Picard",
    "updated_at" : ISODate("2024-06-28T09:32:02.401+0000"),
    "created_at" : ISODate("2024-06-28T09:32:02.401+0000"),
    "planetIds" : [
        {
            "oid" : "667e831289f74871500d80a2"
        },
        {
            "oid" : "667e831289f74871500d80a3"
        },
        {
            "oid" : "667e831289f74871500d80a4"
        }
    ]
}

With the type check, the cast is adapted to avoid converting an object into an associative array.

{
    "_id" : ObjectId("667e91e6bfeefc593308f745"),
    "name" : "Tanya Kirbuk",
    "updated_at" : ISODate("2024-06-28T10:35:18.459+0000"),
    "created_at" : ISODate("2024-06-28T10:35:18.459+0000"),
    "planetIds" : [
        ObjectId("667e91e6bfeefc593308f742"),
        ObjectId("667e91e6bfeefc593308f743"),
        ObjectId("667e91e6bfeefc593308f744")
    ]
}

3015

Checklist

• [x] Add tests and ensure they pass
• [ ] Add an entry to the CHANGELOG.md file
• [ ] Update documentation for new features

[alcaeus]

Can you please add tests for this change? Thank you!

[florianJacques]

Can you please add tests for this change? Thank you!

Yes of course when I have a little time. I missed the sync/toggle functions. I still have work to do.

[florianJacques]

Add Test OK.

[GromNaN]

Sorry for the time it takes to review your PR. This part of the code is complicated and we need to ensure this is feature we can support and maintain for the long run. The more we copy and modify code from the parent class, the more difficult it is to maintain and keep compatibility with multiple versions of Laravel version (even minor version can break). Also, I guess belongsToMany is not the only type of relationship that would need such change.

[florianJacques]

Sorry for the time it takes to review your PR. This part of the code is complicated and we need to ensure this is feature we can support and maintain for the long run. The more we copy and modify code from the parent class, the more difficult it is to maintain and keep compatibility with multiple versions of Laravel version (even minor version can break). Also, I guess belongsToMany is not the only type of relationship that would need such change.

No problem, the big change is in the "formatRecordsList" method, which currently assumes the existence of a pivot table.