search

mongodb / mongo-jdbc-driver

JDBC Driver for MongoDB Atlas SQL interface
Apache License 2.0
36 stars 33 forks source link

SQL-906: Remove dialect option from JDBC API #104

Closed mattChiaravalloti closed 2 years ago

mattChiaravalloti commented 2 years ago

This PR removes the DIALECT property from the MongoDriver class. This also requires removing the MySQLIntegrationTest class since there is no longer a way to create a MySQLConnection through the MongoDriver api. There is also some other clean up MongoDriverTest -- removing DIALECT testing -- and build.gradle -- removing the reference to MySQLIntegrationTest.

This PR does not remove all of the now-dead code that supports the MySQL dialect. That should be done as part of a separate follow-up ticket that considers exactly how the codebase should be factored after the MySQL stuff is removed. For example, will we want to keep the abstract classes everywhere? Will we want to keep the MongoSQL prefix on everything? etc. This PR is just removing the dialect from the public-facing api by no longer supporting the DIALECT property.

mattChiaravalloti commented 2 years ago

There are a couple of places where the dialect property is being set: in the smoketest, and the demo test utils. It would be good to remove these as well.

Thanks for catching that! The other uses of "dialect", such as the comments in MySQLConnection and MongoSQLConnection, will stay for now until that future ticket that removes MySQL* dead code is done!

mattChiaravalloti commented 2 years ago

evergreen merge