search

mongodb / mongo-jdbc-driver

JDBC Driver for MongoDB Atlas SQL interface
Apache License 2.0
36 stars 33 forks source link

SQL-573: Add Apache 2.0 license #106

Closed mattChiaravalloti closed 2 years ago

mattChiaravalloti commented 2 years ago

This PR adds the apache 2.0 license to the repo, along with copyright headers to all source code files. It looks like the release already includes the license. I updated spotless to handle this for us. Now, spotlessCheck will fail if a source file does not start with a license header, and spotlessApply will write the header for us whenever it is missing.

Open Question Should the header be added to the java files in demo and smoketest? If so, should that also be done through spotless? Right now, those directories are not inspected by spotless, so I think I'd have to update their gradle.build files and probably update the evergreen task to check those as well.

nbagnard commented 2 years ago

I'm ambivalent about the license headers in demo and smoketest, and I'm also not totally sure what the java ecosystem convention would be here.

I think we can leave it. I don't know of a specific convention regarding test apps. In my experience, most of the time the header is just added de-facto to any new file in the project.

mattChiaravalloti commented 2 years ago

evergreen merge