search

mongodb / mongo-jdbc-driver

JDBC Driver for MongoDB Atlas SQL interface
Apache License 2.0
37 stars 33 forks source link

SQL-507: Refactor into base classes and MySQL and MongoSQL subclasses #44

Closed mattChiaravalloti closed 2 years ago

mattChiaravalloti commented 2 years ago

This PR refactors the base Mongo* classes into abstract classes and introduces completed MySQL* implementations and stub MongoSQL* implementations. There are no logic changes in this PR. All changes are purely refactors.

mattChiaravalloti commented 2 years ago

Replaced @rychipman with @bucaojit as a reviewer, based on discussion in stand up.

pmeredit commented 2 years ago

@mattChiaravalloti I updated the Design Doc to cover all the public methods that need to be moved out of MongoDatabaseMetadata. They are now in utf-8 order, also

mattChiaravalloti commented 2 years ago

@mattChiaravalloti I updated the Design Doc to cover all the public methods that need to be moved out of MongoDatabaseMetadata. They are now in utf-8 order, also

thanks! updated

mattChiaravalloti commented 2 years ago

The evergreen failures are the same ones that are already failing on master, btw