search

mongodb / mongo-jdbc-driver

JDBC Driver for MongoDB Atlas SQL interface
Apache License 2.0
37 stars 33 forks source link

SQL-551: Implement MongoSQLDatabaseMetaData methods that return empty result sets #52

Closed mattChiaravalloti closed 2 years ago

mattChiaravalloti commented 2 years ago

This PR implements the MongoSQLDatabaseMetaData methods that return empty result sets. For now, this is blocked on SQL-513 and SQL-535, but there is some progress to be reviewed. Specifically the BsonExplicitCursor, the methodology for returning an empty result set (a static member of that class), and the testing methodology for {Mongo|My}SQLDatabaseMetaData.

mattChiaravalloti commented 2 years ago

@pmeredit @nbagnard @bucaojit There have been some non-trivial changes to this PR in all classes, including the tests, as a result of the rebases and new functionality available. Specifically, the creation of result set metadata in each of the database metadata methods and how the tests deal with different column orders for the two dialects. I anticipate the changes being generally uncontroversial, but retagged all of you since the current state of the PR is quite different than when you approved. If you do not want to do a full review, that is ok! Only 2 of you should suffice but I'll leave that up to your discretion.