mongodb / mongo-jdbc-driver

JDBC Driver for MongoDB Atlas SQL interface
Apache License 2.0
37 stars 33 forks source link

SQL-557: Update functions categorization #58

Closed nbagnard closed 2 years ago

nbagnard commented 2 years ago

Update the functions categorization based on the JDBC spec. Started refactoring to split Mysql and MongoSql specific code since the supported functions are different.

nbagnard commented 2 years ago

Other changes made regarding the existing function list are :

nbagnard commented 2 years ago

Note : MongoDatabaseMetaDataTest > testGetFunctions() is failing because there are now 2 more functions reported. ATAN with 2 arguments and SUBSTRING with 3 arguments. I'll update the expected results once Matt's changes are merged.

nbagnard commented 2 years ago

nit: I would prefer if we named the classes MySQLFunctions and MongoSQLFunctions, but otherwise looks great!

Sure, I used to always use the parent class name as a suffix, but I agree it doesn't bring much here. Just makes the class names very long.