search

mongodb / mongo-jdbc-driver

JDBC Driver for MongoDB Atlas SQL interface
Apache License 2.0
36 stars 33 forks source link

SQL-729: Add support for local mongohoused #79

Closed henretty closed 2 years ago

henretty commented 2 years ago

Updates run_adl.sh to allow using a local copy of mongohouse source. This is enabled with the HAVE_LOCAL_MONGOHOUSE and LOCAL_MONGOHOUSE_DIR environment variables.

The only change to previous default behavior is that mqlrun and the mongosql library are downloaded on every run. This is a DevX change as it 1) guarantees that these tools are the newest available and 2) guarantees OS compatibility when e.g., using a mac and running run_adl.sh in a linux container with mongohouse source mounted from the mac.

henretty commented 2 years ago

@bucaojit @nbagnard Another review requested as I added some non-trivial logic to restore mongosql and libmongosql.a to their original versions when running with a local mongohouse source tree.

This is to ensure that we don't end up with binaries for an incompatible OS e.g., if a developer is on a Mac and they run the ADL tests on a Linux container.

This change only substantially affects behavior when run with HAVE_LOCAL_MONGOHOUSE.

henretty commented 2 years ago

I don't have permissions to merge. @bucaojit can you do this?