search

mongodb / mongo-jdbc-driver

JDBC Driver for MongoDB Atlas SQL interface
Apache License 2.0
36 stars 33 forks source link

SQL-761: Disable Mysql dialect related tests #85

Closed nbagnard closed 2 years ago

nbagnard commented 2 years ago

Disabled TDVT and MySQLIntegrationTest but kept the code in for now. Will remove the code when Mysql dialect is removed.

henretty commented 2 years ago

@bucaojit @nbagnard I'm still seeing the TDVT test running when using commit 96b86cf. Am i missing something or did anything change in how the test needs to be executed? Below is the output of ./gradlew clean build:

> Task :compileTdvtTestJava
> Task :processTdvtTestResources NO-SOURCE
> Task :tdvtTestClasses

> Task :tdvtTest FAILED

com.mongodb.jdbc.tdvt.TDVTTest > testLOGICAL_CALCS3 FAILED
    java.lang.ExceptionInInitializerError at NativeConstructorAccessorImpl.java:-2
        Caused by: java.lang.RuntimeException at TDVTTest.java:23
            Caused by: java.lang.NullPointerException at TDVTTest.java:29

com.mongodb.jdbc.tdvt.TDVTTest > testLOGICAL_CALCS4 FAILED
    java.lang.NoClassDefFoundError at NativeConstructorAccessorImpl.java:-2

com.mongodb.jdbc.tdvt.TDVTTest > testLOGICAL_CALCS8 FAILED
    java.lang.NoClassDefFoundError at NativeConstructorAccessorImpl.java:-2
henretty commented 2 years ago

It looks like this only happens if the MySQL test env vars are unset. To repro:

unset ADL_TEST_HOST ADL_TEST_USER ADL_TEST_PWD ADL_TEST_AUTH_DB ./gradlew clean build

bucaojit commented 2 years ago

@henretty @nbagnard This check.dependsOn may be why the tdvt test is still running. Checking gradle docs.

henretty commented 2 years ago

Thanks @bucaojit , it looks like @nbagnard 's latest commit has got everything working on the ADL side! Thank you all!