search

mongodb / mongo-perf

performance tools for mongodb
350 stars 139 forks source link

PERF-3459 Refactor testcases/simple_query.js #114

Closed mtandrei closed 1 year ago

mtandrei commented 1 year ago

EDIT forgot the EVG link! Oops

Evergreen: https://spruce.mongodb.com/version/6373f8bfc9ec44735aa39b97/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

Surprisingly, no extra work was needed to get these tests to run (see: Sort queries; In queries; Indexed queries

Now, a surprise here is that some of the tests appear to have regressed significantly as result of these changes (see Queries.PointQuery_SingleIndex_LL in the following task). I'm not sure what may have caused this; I tried reverting the refactor locally and this doesn't move the needle at all. I'm going to inspect the patch build further. Maybe it's an issue with the additions to utils.js?

mtandrei commented 1 year ago

Evergreen: https://spruce.mongodb.com/version/637e82a53627e0072a207f91/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

I reverted spinning indexed queries into their own file and this seems to have gotten rid of the large collection regressions that I was seeing. PTAL when you have the chance.

mtandrei commented 1 year ago

Thanks for the review Zixuan! Per offline discussion, I wasn't able to get to the bottom of the cause of the regression (it's a non issue now because the indexed tests are now remaining in 'simple_query.js'